From 2ae0cd8a8dc6d630ee1a7a84ddf6111609dbdeb7 Mon Sep 17 00:00:00 2001 From: HombreLaser Date: Thu, 30 Mar 2023 17:29:40 -0600 Subject: Mejora la estructura de los specs --- .../create_companies_controller_spec.rb | 34 ---------------------- spec/requests/companies_controller/create_spec.rb | 34 ++++++++++++++++++++++ .../index_companies_controller_spec.rb | 16 ---------- spec/requests/companies_controller/index_spec.rb | 16 ++++++++++ .../show_companies_controller_spec.rb | 13 --------- spec/requests/companies_controller/show_spec.rb | 13 +++++++++ .../update_companies_controller_spec.rb | 26 ----------------- spec/requests/companies_controller/update_spec.rb | 26 +++++++++++++++++ 8 files changed, 89 insertions(+), 89 deletions(-) delete mode 100644 spec/requests/companies_controller/create_companies_controller_spec.rb create mode 100644 spec/requests/companies_controller/create_spec.rb delete mode 100644 spec/requests/companies_controller/index_companies_controller_spec.rb create mode 100644 spec/requests/companies_controller/index_spec.rb delete mode 100644 spec/requests/companies_controller/show_companies_controller_spec.rb create mode 100644 spec/requests/companies_controller/show_spec.rb delete mode 100644 spec/requests/companies_controller/update_companies_controller_spec.rb create mode 100644 spec/requests/companies_controller/update_spec.rb (limited to 'spec/requests/companies_controller') diff --git a/spec/requests/companies_controller/create_companies_controller_spec.rb b/spec/requests/companies_controller/create_companies_controller_spec.rb deleted file mode 100644 index 219868b..0000000 --- a/spec/requests/companies_controller/create_companies_controller_spec.rb +++ /dev/null @@ -1,34 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -RSpec.describe 'POST /api/companies', type: :request do - let(:company) { build(:company) } - let(:logo) { fixture_file_upload('tres castillos-2.png', 'image/png') } - - it_behaves_like 'a POST request' do - let(:user) { create(:user_account, role: 'master') } - let(:token) { jwt(user) } - let(:headers) { { 'CONTENT_TYPE' => 'application/json', 'Authorization' => "Bearer #{token['token']}" } } - let(:route) { '/api/companies' } - let(:expected_error_messages) do - ["Name can't be blank", "Short name can't be blank", "Country can't be blank"] - end - let(:desired_error_status) { 422 } - let(:expected_text) { [company.name, company.short_name, company.country, 'logo', 'http'] } - let(:params) do - { name: company.name, short_name: company.short_name, country: company.country, logo: } - end - let(:wrong_params) { JSON.generate({ name: '', short_name: '', country: '' }) } - end - - it_behaves_like 'a POST request that requires a master user' do - let(:user) { create(:user_account, role: 'regular') } - let(:token) { jwt(user) } - let(:headers) { { 'CONTENT_TYPE' => 'application/json', 'Authorization' => "Bearer #{token['token']}" } } - let(:route) { '/api/companies' } - let(:params) do - JSON.generate({ name: company.name, short_name: company.short_name, country: company.country }) - end - end -end diff --git a/spec/requests/companies_controller/create_spec.rb b/spec/requests/companies_controller/create_spec.rb new file mode 100644 index 0000000..219868b --- /dev/null +++ b/spec/requests/companies_controller/create_spec.rb @@ -0,0 +1,34 @@ +# frozen_string_literal: true + +require 'rails_helper' + +RSpec.describe 'POST /api/companies', type: :request do + let(:company) { build(:company) } + let(:logo) { fixture_file_upload('tres castillos-2.png', 'image/png') } + + it_behaves_like 'a POST request' do + let(:user) { create(:user_account, role: 'master') } + let(:token) { jwt(user) } + let(:headers) { { 'CONTENT_TYPE' => 'application/json', 'Authorization' => "Bearer #{token['token']}" } } + let(:route) { '/api/companies' } + let(:expected_error_messages) do + ["Name can't be blank", "Short name can't be blank", "Country can't be blank"] + end + let(:desired_error_status) { 422 } + let(:expected_text) { [company.name, company.short_name, company.country, 'logo', 'http'] } + let(:params) do + { name: company.name, short_name: company.short_name, country: company.country, logo: } + end + let(:wrong_params) { JSON.generate({ name: '', short_name: '', country: '' }) } + end + + it_behaves_like 'a POST request that requires a master user' do + let(:user) { create(:user_account, role: 'regular') } + let(:token) { jwt(user) } + let(:headers) { { 'CONTENT_TYPE' => 'application/json', 'Authorization' => "Bearer #{token['token']}" } } + let(:route) { '/api/companies' } + let(:params) do + JSON.generate({ name: company.name, short_name: company.short_name, country: company.country }) + end + end +end diff --git a/spec/requests/companies_controller/index_companies_controller_spec.rb b/spec/requests/companies_controller/index_companies_controller_spec.rb deleted file mode 100644 index c8fb439..0000000 --- a/spec/requests/companies_controller/index_companies_controller_spec.rb +++ /dev/null @@ -1,16 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -RSpec.describe 'GET /api/companies', type: :request do - before(:each) do - create_list(:company, 12) - end - - it_behaves_like 'a GET index request' do - let(:headers) { {} } - let(:companies) { create_list(:company, 12) } - let(:route) { '/api/companies' } - let(:pagination_size) { 10 } - end -end diff --git a/spec/requests/companies_controller/index_spec.rb b/spec/requests/companies_controller/index_spec.rb new file mode 100644 index 0000000..c8fb439 --- /dev/null +++ b/spec/requests/companies_controller/index_spec.rb @@ -0,0 +1,16 @@ +# frozen_string_literal: true + +require 'rails_helper' + +RSpec.describe 'GET /api/companies', type: :request do + before(:each) do + create_list(:company, 12) + end + + it_behaves_like 'a GET index request' do + let(:headers) { {} } + let(:companies) { create_list(:company, 12) } + let(:route) { '/api/companies' } + let(:pagination_size) { 10 } + end +end diff --git a/spec/requests/companies_controller/show_companies_controller_spec.rb b/spec/requests/companies_controller/show_companies_controller_spec.rb deleted file mode 100644 index fc5bbd0..0000000 --- a/spec/requests/companies_controller/show_companies_controller_spec.rb +++ /dev/null @@ -1,13 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -RSpec.describe 'GET /api/companies/:short_name', type: :request do - it_behaves_like 'a GET resource request' do - let(:headers) { {} } - let(:company) { create(:company) } - let(:route) { "/api/companies/#{company.short_name}" } - let(:invalid_route) { "/api/companies/#{Faker::Lorem.word}" } - let(:expected_text) { [company.name, company.id.to_s, company.short_name, company.country] } - end -end diff --git a/spec/requests/companies_controller/show_spec.rb b/spec/requests/companies_controller/show_spec.rb new file mode 100644 index 0000000..fc5bbd0 --- /dev/null +++ b/spec/requests/companies_controller/show_spec.rb @@ -0,0 +1,13 @@ +# frozen_string_literal: true + +require 'rails_helper' + +RSpec.describe 'GET /api/companies/:short_name', type: :request do + it_behaves_like 'a GET resource request' do + let(:headers) { {} } + let(:company) { create(:company) } + let(:route) { "/api/companies/#{company.short_name}" } + let(:invalid_route) { "/api/companies/#{Faker::Lorem.word}" } + let(:expected_text) { [company.name, company.id.to_s, company.short_name, company.country] } + end +end diff --git a/spec/requests/companies_controller/update_companies_controller_spec.rb b/spec/requests/companies_controller/update_companies_controller_spec.rb deleted file mode 100644 index fd23365..0000000 --- a/spec/requests/companies_controller/update_companies_controller_spec.rb +++ /dev/null @@ -1,26 +0,0 @@ -# frozen_string_literal: true - -require 'rails_helper' - -RSpec.describe 'PUT /api/companies/company_id', type: :request do - let(:user) { create(:user_account, role: 'master') } - let(:company) { create(:company) } - let(:new_company) { build(:company) } - let(:logo) { fixture_file_upload('tres castillos-2.png', 'image/png') } - let(:token) { jwt(user) } - - it_behaves_like 'a PUT request' do - let(:headers) { { 'Authorization' => "Bearer #{token['token']}" } } - let(:route) { "/api/companies/#{company.short_name}" } - let(:wrong_route) { "/api/companies/#{SecureRandom.hex(8)}" } - let(:expected_error_messages) do - ["Name can't be blank", "Short name can't be blank", "Country can't be blank"] - end - let(:expected_text) { [new_company.name, new_company.short_name, new_company.country, 'logo', 'http'] } - let(:params) do - { name: new_company.name, short_name: new_company.short_name, country: new_company.country, - logo: fixture_file_upload('tres castillos-2.png', 'image/png') } - end - let(:wrong_params) { { name: '', short_name: '', country: '' } } - end -end diff --git a/spec/requests/companies_controller/update_spec.rb b/spec/requests/companies_controller/update_spec.rb new file mode 100644 index 0000000..fd23365 --- /dev/null +++ b/spec/requests/companies_controller/update_spec.rb @@ -0,0 +1,26 @@ +# frozen_string_literal: true + +require 'rails_helper' + +RSpec.describe 'PUT /api/companies/company_id', type: :request do + let(:user) { create(:user_account, role: 'master') } + let(:company) { create(:company) } + let(:new_company) { build(:company) } + let(:logo) { fixture_file_upload('tres castillos-2.png', 'image/png') } + let(:token) { jwt(user) } + + it_behaves_like 'a PUT request' do + let(:headers) { { 'Authorization' => "Bearer #{token['token']}" } } + let(:route) { "/api/companies/#{company.short_name}" } + let(:wrong_route) { "/api/companies/#{SecureRandom.hex(8)}" } + let(:expected_error_messages) do + ["Name can't be blank", "Short name can't be blank", "Country can't be blank"] + end + let(:expected_text) { [new_company.name, new_company.short_name, new_company.country, 'logo', 'http'] } + let(:params) do + { name: new_company.name, short_name: new_company.short_name, country: new_company.country, + logo: fixture_file_upload('tres castillos-2.png', 'image/png') } + end + let(:wrong_params) { { name: '', short_name: '', country: '' } } + end +end -- cgit v1.2.3